fix(auth): handle ENOTDIR when opening cert config #10697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
added
the
do not merge
codyoss
requested changes
Aug 21, 2024
codyoss
removed
the
do not merge
dfinkel
force-pushed
the
auth_ENOTDIR_fix_client_certificate_init
branch
2 times, most recently
from
b4f7650 to
eb7bb72
Compare
codyoss
approved these changes
Aug 22, 2024
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
changed the title
dfinkel
force-pushed
the
auth_ENOTDIR_fix_client_certificate_init
branch
from
934674d to
a60add3
Compare
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Failing test: |
jba
reviewed
Aug 22, 2024
|
Oh, right! I'll update it to skip that test when the UID is |
Some users explicitly have their home directories set to `/dev/null`. When opening a file that's "under that directory", instead of getting the normal `ENOENT`, one should expect to get `ENOTDIR`. Unfortunately, due to the variety of cases under which `ENOTDIR` is returned, the go team has declined to include ENOTDIR in `ErrNotExist`. (https://golang.org/issues/18974) The most robust solution in this case (following [1]) is to treat any read error as `errSourceUnavailable`. This has the mixed-benefit of also covering EPERM. (hopefully this doesn't make it too hard to track down permissions problems for secure connect users) Resolves: googleapis#10696 [1]: https://go-review.googlesource.com/c/oauth2/+/493695
dfinkel
force-pushed
the
auth_ENOTDIR_fix_client_certificate_init
branch
from
e26a384 to
10b2435
Compare
|
Ok, I've rebased and pushed a guard to skip the EPERM test when the UID is 0. |
codyoss
approved these changes
Aug 22, 2024
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users explicitly have their home directories set to
/dev/null. When opening a file that's "under that directory", instead of getting the normalENOENT, one should expect to getENOTDIR.Unfortunately, due to the variety of cases under which
ENOTDIRis returned, the go team has declined to include ENOTDIR inErrNotExist. (https://golang.org/issues/18974)The most robust solution in this case (following 1) is to treat any
read error as
errSourceUnavailable. This has the mixed-benefit of alsocovering EPERM. (hopefully this doesn't make it too hard to track down
permissions problems for secure connect users)
Resolves: #10696